Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List favorite team's game(s) first #43

Closed
wants to merge 1 commit into from

Conversation

thromer
Copy link

@thromer thromer commented May 21, 2022

No description provided.

@tonywagner
Copy link
Contributor

This one may not be necessary, as my latest pull request includes an "autoplay favorite team when live" option, as requested: #44

@thromer
Copy link
Author

thromer commented May 22, 2022

This one may not be necessary, as my latest pull request includes an "autoplay favorite team when live" option, as requested: #44

I think #43 would still be useful on its own, since autoplay doesn't always apply.

@tonywagner
Copy link
Contributor

That makes sense. Since my PR also modified the create_game_listitem function, I just rolled your changes into my PR, if you want to update and test.

@thromer
Copy link
Author

thromer commented May 24, 2022

Thanks! My laptop just went belly-up so I won't be able to test it unfortunately.

@tonywagner
Copy link
Contributor

No problem, I think I've watched enough baseball to test it thoroughly the past few days. :)

In any case, I think this PR can be closed now. Thanks for the contribution!

@eracknaphobia
Copy link
Owner

@thromer @tonywagner Thanks for the updates!
So we are closing this PR and pulling #44, correct?

@tonywagner
Copy link
Contributor

So we are closing this PR and pulling #44, correct?

Yes, #44 now incorporates the changes from this PR too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants