Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKDSpectralContext: Add default bin set, remove direct constructor calls #205

Merged
merged 1 commit into from Apr 13, 2022

Conversation

leroyvn
Copy link
Member

@leroyvn leroyvn commented Apr 13, 2022

Description

This PR sets more complete defaults for the CKDSpectralContext class. The missing default value for the bin_set parameter would indeed be problematic when passing an instance missing a value.

A few tests are refactored for improved scoping. Direct calls to the CKDSpectralContext() constructor are also removed (a SpectralContext.new() is always preferred).

Checklist

  • The code follows the relevant coding guidelines
  • The code generates no new warnings
  • The code is appropriately documented
  • The code is tested to prove its function
  • The feature branch is rebased on the current state of the main branch
  • I give permission that the Eradiate project may redistribute my contributions under the terms of its license

@leroyvn leroyvn merged commit d94f213 into main Apr 13, 2022
@leroyvn leroyvn deleted the spectral_context_default branch April 13, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant