Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AstroObjectIllumination: Minor fixes #346

Merged
merged 1 commit into from Jun 26, 2023
Merged

AstroObjectIllumination: Minor fixes #346

merged 1 commit into from Jun 26, 2023

Conversation

leroyvn
Copy link
Member

@leroyvn leroyvn commented Jun 22, 2023

Description

This PR fixes minor issues with the new AstroObjectIllumination. Namely:

  • Changed the default value of the angular_diameter parameter to something more useful in the context of remote sensing
  • Fixed factory ID and filename inconsistencies
    *Apply a formatter pass
  • Fix and simplify documentation

@wint3ria I removed a AstroObjectIllumination.astro_object() class method constructor because it didn't seem to be used anywhere; please let me know if this is useful somewhere and I'll happily roll back.

Checklist

  • The code follows the relevant coding guidelines
  • The code generates no new warnings
  • The code is appropriately documented
  • The code is tested to prove its function
  • The feature branch is rebased on the current state of the main branch
  • I updated the change log if relevant
  • I give permission that the Eradiate project may redistribute my contributions under the terms of its license

@wint3ria
Copy link
Contributor

The factory is indeed superfluous

@leroyvn
Copy link
Member Author

leroyvn commented Jun 26, 2023

Thanks @wint3ria, I'll merge this now.

@leroyvn leroyvn merged commit 8935cf9 into main Jun 26, 2023
@leroyvn leroyvn deleted the fix_astro_object branch June 26, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants