Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different package specifications for Pip and Conda #385

Merged
merged 1 commit into from Jan 14, 2024

Conversation

leroyvn
Copy link
Member

@leroyvn leroyvn commented Jan 11, 2024

Description

This commit allows different package specifications for Pip and Conda. In practice, dependencies can now be specified either this way:

main:
  packages:
    - "attrs>=22.2"

or that way:

recommended:
  packages:
    - pip: "graphviz>=0.20"
      conda: "python-graphviz>=0.20"

This allows using different package names for Pip and Conda.

Checklist

  • The code follows the relevant coding guidelines
  • The code generates no new warnings
  • The code is appropriately documented
  • The code is tested to prove its function
  • The feature branch is rebased on the current state of the main branch
  • I updated the change log if relevant
  • I give permission that the Eradiate project may redistribute my contributions under the terms of its license

@leroyvn leroyvn requested a review from wint3ria January 11, 2024 12:45
@leroyvn leroyvn changed the title Reqs: Allow different package specifications for Pip and Conda Allow different package specifications for Pip and Conda Jan 11, 2024
Copy link
Contributor

@wint3ria wint3ria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@leroyvn leroyvn merged commit ff03538 into main Jan 14, 2024
@leroyvn leroyvn deleted the different_package_specs branch January 14, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants