Fix HTML multiline comments bug (quantizor#246)

eragon512 · Aug 7, 2019 · df83a77 · df83a77
1 parent ce11e49
commit df83a77
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/index.compiler.spec.js b/index.compiler.spec.js
@@ -1972,6 +1972,21 @@ describe('arbitrary HTML', () => {
   Foo
 </p>
 
+`);
+  });
+
+  it('throws out multiline HTML comments', () => {
+    render(compiler(`Foo\n<!-- this is
+a
+multiline
+comment -->`));
+
+    expect(root.innerHTML).toMatchInlineSnapshot(`
+
+<p data-reactroot>
+  Foo
+</p>
+
 `);
   });
 

diff --git a/index.js b/index.js
@@ -6,6 +6,7 @@
  */
 import React from 'react';
 import unquote from 'unquote';
+import stripHtmlComments from 'strip-html-comments';
 
 /** TODO: Drop for React 16? */
 const ATTRIBUTE_TO_JSX_PROP_MAP = {
@@ -1552,7 +1553,7 @@ export function compiler(markdown, options) {
   const parser = parserFor(rules);
   const emitter = reactFor(ruleOutput(rules));
 
-  const jsx = compile(markdown);
+  const jsx = compile(stripHtmlComments(markdown));
 
   if (footnotes.length) {
     jsx.props.children.push(

diff --git a/package.json b/package.json
@@ -70,6 +70,7 @@
   },
   "dependencies": {
     "prop-types": "^15.6.2",
+    "strip-html-comments": "^1.0.0",
     "unquote": "^1.1.0"
   },
   "peerDependencies": {