Skip to content
This repository has been archived by the owner on Aug 18, 2023. It is now read-only.

Focused tweet not highlighted in Old Gray / Super Black themes #548

Closed
mkobayashime opened this issue Apr 5, 2021 · 0 comments · Fixed by #547
Closed

Focused tweet not highlighted in Old Gray / Super Black themes #548

mkobayashime opened this issue Apr 5, 2021 · 0 comments · Fixed by #547
Labels

Comments

@mkobayashime
Copy link

Describe the bug

In Light/Dark theme (and in the vanilla TweetDeck) keyboard focused tweet (selected with arrow/hjkl keys) is displayed with a slightly lighter/darker background color to indicate it's focused/selected, but it doesn't in Old Gray / Super Black themes (added in the v4, I guess).

Comparison with the all 4 themes with the 2nd tweet selected.

Light Dark Old Gray Super Black
tweetdeck twitter com_ (4) tweetdeck twitter com_ (5) tweetdeck twitter com_ (2) tweetdeck twitter com_ (3)

To Reproduce

Steps to reproduce the behavior:

  1. Open TweetDeck with Old Gray or Super Black theme.
  2. Select some tweet using arrow/hjkl keys.

Expected behavior

Focused/selected tweet can be told apart.

Desktop (please complete the following information):

  • OS: Ubuntu 20.04
  • Browser: Chrome Version 89.0.4389.114 / FireFox 87.0
  • Version: Better TweetDeck 4.0.0
eramdam added a commit that referenced this issue Apr 5, 2021
@eramdam eramdam mentioned this issue Apr 5, 2021
eramdam added a commit that referenced this issue Apr 6, 2021
* 🤦

* Character counter setting

* request tabs permission on Firefox to fix share item

* re-add setting to show dog ears

* don't override unread DM styles

* Old grey tweaks

* Remove custom bottom border color in dark theme

* Add a link to CSS snippets in the wiki

* affect horizontal scrollbar with thin scrollbars on Firefox

Fixes #542

* Update settingsModal.tsx

* Don't render cards inside of columns with "hidden" media previews

Fixes #550

* don't change background of selected tweets

Fixes #548

* Allow for OG aspect ratio in quoted images

Fixes #541

* Keep "new" badge for 5 minor versions at least

* Add Japanese translations (#549)

* Add Japanese translations

* fix translation

* Update README.md

* Update package.json

* Update README.md

* Add crowdin link

Co-authored-by: noriokun4649 <souta46493yoroosiku@yahoo.co.jp>
eramdam added a commit that referenced this issue Apr 6, 2021
* 🤦

* Character counter setting

* request tabs permission on Firefox to fix share item

* re-add setting to show dog ears

* don't override unread DM styles

* Old grey tweaks

* Remove custom bottom border color in dark theme

* Add a link to CSS snippets in the wiki

* affect horizontal scrollbar with thin scrollbars on Firefox

Fixes #542

* Update settingsModal.tsx

* Don't render cards inside of columns with "hidden" media previews

Fixes #550

* don't change background of selected tweets

Fixes #548

* Allow for OG aspect ratio in quoted images

Fixes #541

* Keep "new" badge for 5 minor versions at least

* New translations messages.json (French)

* New translations messages.json (Japanese)

* Add Japanese translations (#549)

* Add Japanese translations

* fix translation

* New translations messages.json (French)

* New translations messages.json (Japanese)

* New translations messages.json (French)

* New translations messages.json (Dutch)

* New translations messages.json (Vietnamese)

* New translations messages.json (Chinese Traditional)

* New translations messages.json (Ukrainian)

* New translations messages.json (Turkish)

* New translations messages.json (Swedish)

* New translations messages.json (Serbian (Cyrillic))

* New translations messages.json (Russian)

* New translations messages.json (Portuguese)

* New translations messages.json (Polish)

* New translations messages.json (Norwegian)

* New translations messages.json (Korean)

* New translations messages.json (Japanese)

* New translations messages.json (Italian)

* New translations messages.json (Hungarian)

* New translations messages.json (Hebrew)

* New translations messages.json (Finnish)

* New translations messages.json (Greek)

* New translations messages.json (German)

* New translations messages.json (Danish)

* New translations messages.json (Czech)

* New translations messages.json (Catalan)

* New translations messages.json (Arabic)

* New translations messages.json (Afrikaans)

* New translations messages.json (Spanish)

* New translations messages.json (Romanian)

* New translations messages.json (Portuguese, Brazilian)

* New translations messages.json (Japanese)

* New translations messages.json (Portuguese, Brazilian)

* New translations messages.json (Portuguese, Brazilian)

* New translations messages.json (French)

* New translations messages.json (Czech)

* New translations messages.json (German)

* New translations messages.json (Japanese)

* New translations messages.json (English)

* New translations messages.json (Portuguese, Brazilian)

* Revert "New translations messages.json (English)"

This reverts commit 098caf4.

* New translations messages.json (English)

* restore eng

* remove extra locales for now

Co-authored-by: noriokun4649 <souta46493yoroosiku@yahoo.co.jp>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant