Remove t.co redirection even on profile website link #590
Conversation
hiroto7
force-pushed
the
RemoveRedirection
branch
from
1032a26
to
9ad4c8d
Compare
src/features/removeRedirection.ts
Outdated
| @@ -29,4 +30,16 @@ export const maybeRemoveRedirection = makeBTDModule(({TD, settings}) => { | |||
|
|
|||
| return result; | |||
| }; | |||
|
|
|||
| TD.services.TwitterUser.prototype.getExpandedURL = function () { | |||
| return this.entities.url.urls[0].expanded_url; | |||
There was a problem hiding this comment.
Could we add some checks here? I feel like this might crash if a given user doesn't have an url?
There was a problem hiding this comment.
As far as the code in this PR, getExpandedURL() is not called for users who do not have a website link so that no crash will occur.
However, with this, templates such as {{#getExpandedURL}} ... {{/getExpandedURL}} cause crash, now I think we should add an existence check too.
So, I'll add the check similar to TD.services.TwitterUser.prototype.getDisplayURL (implemented by original TweetDeck)!
There was a problem hiding this comment.
@hiroto7 sounds good! I prefer to be extra careful because crashing in there can have weird consequences 😅
There was a problem hiding this comment.
I added it in 84ead19.
Fixes #416.
Since the method
createUrlAnchor()is not called when rendering the profile website link, I added template modification.