Skip to content

Commit

Permalink
[FEATURE modernized-built-in-components] Implement input attrs deprec…
Browse files Browse the repository at this point in the history
…ation

Tracking issue: https://github.com/emberjs/ember.js/issues/192t 70
More specifically, it enables the <Input> attribute deprecations introduced
in emberjs#19218, fixes broken tests, and
updates all test {{input}} invocations to use <Input> instead.

WIP - add maybeExpectDeprecation function
  • Loading branch information
eramod committed Feb 4, 2021
1 parent 2aa6395 commit eeafa87
Show file tree
Hide file tree
Showing 9 changed files with 471 additions and 300 deletions.
2 changes: 1 addition & 1 deletion packages/@ember/-internals/glimmer/lib/components/input.ts
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
`Passing the \`@${argument}\` argument to <Input> is deprecated. ` +
`Instead, please pass the attribute directly, i.e. \`<Input ${attribute}={{...}} />\` ` +
`instead of \`<Input @${argument}={{...}} />\` or \`{{input ${argument}=...}}\`.`,
true /* TODO !(argument in this.args) */,
!(argument in this.args),
{
id: 'ember.built-in-components.legacy-attribute-arguments',
for: 'ember-source',
Expand Down

0 comments on commit eeafa87

Please sign in to comment.