Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use dark tab theme by default #1510

Merged
merged 1 commit into from Jan 11, 2017
Merged

Add option to use dark tab theme by default #1510

merged 1 commit into from Jan 11, 2017

Conversation

hdastwb
Copy link
Contributor

@hdastwb hdastwb commented Jan 10, 2017

CodeLite's dark tab theme looks really good when used with other dark-themed UI elements, but there isn't currently a good way to configure CodeLite to use that theme (besides the match-editor-theme option, which only works for editor tabs). These changes add a new option to the settings dialog (Windows & Tabs > Docking > Use dark notebook tab theme by default) which allows the user to switch the tabs to the dark theme (when not overridden by the match-editor-theme option). This option is stored using what appears to be a previously unused options bit, and should have all of the logic in place for initializing and updating the color theme of all four of CodeLite's main notebooks.

I've never used wxCrafter before making this small change, and, since it looks like it clobbered pretty much all of the .wxcb file and the related #include guard, I'm worried that I might be doing something wrong or using the wrong version. I can fix those files manually if you want me to.

I'm also not sure if there's anything special that I need to do to get the new text that's added with this change to be localization-ready; if there is, I'll take care of that too.

@eranif
Copy link
Owner

eranif commented Jan 10, 2017

I applied the patch locally and this look OK.
I wonder which version of wxCrafter are you using since I noticed that the wxcp file contains TABS.
While latest versions of wxCrafter are using SPACES (2 chars) to indent which makes the file more readable (to me at least).

Is it also possible to support the following notebooks:

  • NodeJS debugger notebook see class NodeJSDebuggerPane
  • PHP Debugger pane notebook see class PHPDebugPane

@hdastwb
Copy link
Contributor Author

hdastwb commented Jan 11, 2017

I just grabbed the evaluation version off of the website for Ubuntu 16.04; it looks like that puts me on version 2.6.

In any case, I fixed the wxCrafter inconsistencies introduced earlier and updated NodeJSDebuggerPane and PHPDebugPane (along with EvalPane too) so that they should all follow the new setting now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants