Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.0pre5 #5

Merged
merged 4 commits into from
Mar 13, 2019
Merged

v0.1.0pre5 #5

merged 4 commits into from
Mar 13, 2019

Conversation

erayerdin
Copy link
Owner

Changed

  • Moved package docstring to the top.
  • dedented some strings.
  • verify_identity raises TypeError instead of ValueError now

@erayerdin erayerdin added bug Something isn't working enhancement New feature or request labels Mar 13, 2019
@erayerdin erayerdin self-assigned this Mar 13, 2019
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #5 into master will decrease coverage by 8.69%.
The diff coverage is 77.77%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master      #5     +/-   ##
========================================
- Coverage     100%   91.3%   -8.7%     
========================================
  Files           1       1             
  Lines          20      23      +3     
========================================
+ Hits           20      21      +1     
- Misses          0       2      +2
Impacted Files Coverage Δ
pynvi/__init__.py 91.3% <77.77%> (-8.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993fd22...c854410. Read the comment docs.

@erayerdin erayerdin merged commit ef17f65 into master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant