Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to use geom_text instead of geom_label #31

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

gernophil
Copy link
Contributor

I personally like geom_text for labels for then geom_label.

@gernophil
Copy link
Contributor Author

gernophil commented Nov 19, 2023

I changed the code to keep complete compatibility with your original package.
stratum_labels must now (as before) be set as TRUE or FALSE with TRUE as default.
I added another parameter stratum_label_type, which can be set to "label" (default) or "text". Any other value (like "none") will completely disable the labels.

@erblast
Copy link
Owner

erblast commented Dec 5, 2023

ok seems like I need to update the github actions first to safely approve the PR. I will let you know once they are on main and then you will need to rebase and update the PR.

@gernophil
Copy link
Contributor Author

Let me know, what I need to do then :). Wanted to look into the github actions anyway. Never used them :D.

@erblast
Copy link
Owner

erblast commented Dec 6, 2023

hello, I fixed the issue that got me dropped from CRAN (fingers crossed) and updated the gh actions. The master branch has been updated. So on your end can you sync your fork and resolve potential merge conflicts (if any should occurr) and then update the pull request?

Once all the ci/cd checks have passed I can merge.

@gernophil
Copy link
Contributor Author

Hey,

I merged your changes into my fork. This should do it, shouldn't it?

@erblast erblast merged commit 0993abb into erblast:master Dec 7, 2023
5 checks passed
@erblast
Copy link
Owner

erblast commented Dec 7, 2023

perfect, thank you for your contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants