Skip to content

Commit

Permalink
Merge pull request #1747 from afumagalli98/added-unk-exadata
Browse files Browse the repository at this point in the history
Added new unknown exadata measurement
  • Loading branch information
afumagalli98 committed Mar 8, 2024
2 parents e1cb70b + 7d10940 commit cad6e86
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 0 deletions.
22 changes: 22 additions & 0 deletions api-service/domain/oracle_exadata_measurement.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,29 @@ import (
effectivebytes "github.com/ercole-io/ercole/v2/utils/effective_bytes"
)

const (
UNKNOWN_VALUE = "UNKNOWN"
)

type OracleExadataMeasurement struct {
unparsedValue string
Symbol string
Quantity float64
}

func (m OracleExadataMeasurement) String() string {
if m.unparsedValue == UNKNOWN_VALUE {
return UNKNOWN_VALUE
}

return fmt.Sprintf("%f %s", m.Quantity, m.Symbol)
}

func (m OracleExadataMeasurement) Human(symbol string) (string, error) {
if m.unparsedValue == UNKNOWN_VALUE {
return UNKNOWN_VALUE, nil
}

c, err := Convert(m, symbol)
if err != nil {
return "", err
Expand Down Expand Up @@ -83,6 +95,12 @@ func NewOracleExadataMeasurement() *OracleExadataMeasurement {
}
}

func NewUnknownOracleExadataMeasurement() *OracleExadataMeasurement {
return &OracleExadataMeasurement{
unparsedValue: UNKNOWN_VALUE,
}
}

func Convert(m OracleExadataMeasurement, symbol string) (*OracleExadataMeasurement, error) {
if m.String() == "" {
return nil, fmt.Errorf("invalid OracleExadataMeasurement, cannot convert to %s", symbol)
Expand Down Expand Up @@ -145,6 +163,10 @@ func StringToOracleExadataMeasurement(s string) (res *OracleExadataMeasurement,
s = "0B"
}

if s == UNKNOWN_VALUE {
return NewUnknownOracleExadataMeasurement(), nil
}

res = &OracleExadataMeasurement{unparsedValue: s}

f, err := effectivebytes.Float64(s)
Expand Down
10 changes: 10 additions & 0 deletions api-service/domain/oracle_exadata_measurement_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,16 @@ func TestNewOracleExadataMeasurement(t *testing.T) {
assert.Equal(t, expected, actual)
}

func TestNewUnknownOracleExadataMeasurement(t *testing.T) {
expected := &OracleExadataMeasurement{
unparsedValue: "UNKNOWN",
}

actual := NewUnknownOracleExadataMeasurement()

assert.Equal(t, expected, actual)
}

func TestIntToOracleExadataMeasurement(t *testing.T) {
expected := &OracleExadataMeasurement{
unparsedValue: "2 GIB",
Expand Down

0 comments on commit cad6e86

Please sign in to comment.