Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: etcd-election support wait #245

Closed
wants to merge 1 commit into from

Conversation

sfwn
Copy link
Member

@sfwn sfwn commented Feb 21, 2022

What this PR does / why we need it:

etcd-election support wait

Specified Reivewers:

/assign @recallsong

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #245 (078ef52) into master (14fb5e1) will decrease coverage by 0.10%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   38.45%   38.35%   -0.11%     
==========================================
  Files          85       85              
  Lines        4805     4828      +23     
==========================================
+ Hits         1848     1852       +4     
- Misses       2834     2852      +18     
- Partials      123      124       +1     
Impacted Files Coverage Δ
providers/etcd-election/election.go 50.00% <30.76%> (-3.04%) ⬇️
pkg/parallel/future.go 86.20% <0.00%> (-6.90%) ⬇️

@sfwn sfwn force-pushed the feature/election-wait branch 3 times, most recently from 5fe7536 to 55f0571 Compare February 21, 2022 06:09
@sfwn sfwn changed the title etcd-election support wait feat: etcd-election support wait Feb 21, 2022
@sfwn
Copy link
Member Author

sfwn commented Feb 21, 2022

test result:

image

@sfwn sfwn force-pushed the feature/election-wait branch 5 times, most recently from 786f4ff to bfd8b4f Compare February 21, 2022 07:12
@sfwn
Copy link
Member Author

sfwn commented Feb 21, 2022

see #246

@sfwn sfwn closed this Feb 21, 2022
@sfwn sfwn deleted the feature/election-wait branch February 21, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants