Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: upgrade to support Golang 1.22 #319

Merged
merged 15 commits into from
Jun 13, 2024
Merged

refactor: upgrade to support Golang 1.22 #319

merged 15 commits into from
Jun 13, 2024

Conversation

iutx
Copy link
Member

@iutx iutx commented Apr 10, 2024 •
edited
Loading

What this PR does / why we need it:

support golang 1.22

  1. Upgrade etcd client version.
  2. Upgrade protobuf, grpc version.
  3. Upgrade otel sdk version.
  4. Update deprecated ioutil calls.

Used by project playground/go-apm-demo.

Which issue(s) this PR fixes:

Fixes #

Specified Reviewers:

/assign @sfwn @chengjoey

@iutx
support golang 1.22
a068dbf 
Signed-off-by: iutx <root@viper.run>
@iutx
update deprecated ioutil calls
07b5f2d 
Signed-off-by: iutx <root@viper.run>
@erda-bot erda-bot requested review from sfwn and chengjoey April 10, 2024 08:26
@iutx
fix the missing import
af10836 
Signed-off-by: iutx <root@viper.run>
@iutx
upgrade ci golang version
1f3a6f3 
Signed-off-by: iutx <root@viper.run>
@iutx
fix golangci-lint errors
3b428f3 
Signed-off-by: iutx <root@viper.run>
chengjoey
chengjoey approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@chengjoey chengjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update tools/dockerfile and create a new gohub image

@iutx
Copy link
Member Author

iutx commented Jun 7, 2024

Please also update tools/dockerfile and create a new gohub image

done :)
Working in process, a unit test failed beacause of etcd version upgraded.

@iutx iutx changed the title refactor: support golang 1.22 refactor: upgrade to support Golang 1.22 Jun 7, 2024
@erda-bot erda-bot requested a review from chengjoey June 7, 2024 08:27
@iutx iutx marked this pull request as ready for review June 7, 2024 08:36
@iutx
Copy link
Member Author

iutx commented Jun 7, 2024

I think we can work next stage, we need a reasonable amount of time to complete all 1.22 upgrades, not only erda-infra but also erda.
PTAL :) @chengjoey @sfwn

@chengjoey
Copy link
Contributor

I think we can work next stage, we need a reasonable amount of time to complete all 1.22 upgrades, not only erda-infra but also erda. PTAL :) @chengjoey @sfwn

erda-upgrade

sfwn
sfwn requested changes Jun 11, 2024
View reviewed changes
go.sum Outdated Show resolved Hide resolved
@iutx iutx requested a review from sfwn June 11, 2024 03:43
iutx
iutx commented Jun 11, 2024
View reviewed changes
Copy link
Member Author

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfwn wip.

go.mod Outdated Show resolved Hide resolved
@iutx
Copy link
Member Author

iutx commented Jun 11, 2024

I forgot why I did the operation :(, please pay attention when erda upgrading. @chengjoey

@iutx
Copy link
Member Author

iutx commented Jun 11, 2024

I think all job done, please take a look. @sfwn

@sfwn
Copy link
Member

sfwn commented Jun 13, 2024

/approve

@sfwn sfwn merged commit 6a57add into erda-project:master Jun 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfwn sfwn sfwn approved these changes

@chengjoey chengjoey chengjoey approved these changes

@erda-bot erda-bot erda-bot approved these changes

Assignees
No one assigned
Labels
approved refactor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iutx @chengjoey @sfwn @erda-bot