Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support global service annotation #62

Merged

Conversation

iutx
Copy link
Member

@iutx iutx commented Mar 30, 2022

What type of this PR

feat: support global service annotation

Add one of the following kinds:
/kind feature

What this PR does / why we need it:

monitor need collect with annotation, e.g.
image
image

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @sixther-dc @luobily

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@luobily
Copy link
Member

luobily commented Apr 13, 2022

/approve

@luobily luobily merged commit 00946a3 into erda-project:release/2.1 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants