fix: fix custom label require error (#778)

erda-project · Jul 29, 2021 · 5b1e771 · 5b1e771
1 parent c1720c0
commit 5b1e771
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/shell/app/common/components/render-formItem.tsx b/shell/app/common/components/render-formItem.tsx
@@ -207,6 +207,11 @@ export const RenderFormItem = ({
         required,
         message: `${i18n.t('common:please')}${action}${hasColon ? label.slice(0, label.length - 1) : label}`,
       });
+    } else {
+      rules.push({
+        required,
+        message: i18n.t('can not be empty'),
+      });
     }
   }
   if (pattern && !rules.some((r) => r.pattern && r.pattern.source === pattern.source)) {
@@ -240,6 +245,7 @@ export const RenderFormItem = ({
   ) : (
     label
   );
+
   return (
     <FormItem
       label={_label}

diff --git a/shell/app/modules/cmp/pages/networks/common/config.tsx b/shell/app/modules/cmp/pages/networks/common/config.tsx
@@ -56,7 +56,7 @@ export const formConfig = {
   },
   label: {
     Zone: (
-      <div className="label-with-required">
+      <div>
         {i18n.t('dcos:availability zone')}
         &nbsp;&nbsp;
         <Tooltip

diff --git a/shell/app/styles/util.scss b/shell/app/styles/util.scss
@@ -626,16 +626,6 @@
   align-items: flex-start;
 }
 
-.label-with-required::before {
-  content: '*';
-  display: inline-block;
-  margin-right: 4px;
-  color: $red;
-  font-size: 14px;
-  font-family: SimSun, sans-serif;
-  line-height: 1;
-}
-
 .no-prevent {
   .pk-select-arrow {
     pointer-events: all;