Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new theme released 🎉 #2443

Merged
merged 93 commits into from
Dec 30, 2021
Merged

Feature/new theme released 🎉 #2443

merged 93 commits into from
Dec 30, 2021

Conversation

daskyrk
Copy link
Contributor

@daskyrk daskyrk commented Dec 30, 2021

What this PR does / why we need it:

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Does this PR introduce a user interface change?

✅ Yes(screenshot is required)
image

ChangeLog

Language Changelog
🇺🇸 English Upgrade to new theme
🇨🇳 中文 升级为新主题

Does this PR need be patched to older version?

❎ No

Which issue(s) this PR fixes:

Fixes #

@laojun
Copy link
Contributor

laojun commented Dec 30, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Dec 30, 2021
@erda-bot erda-bot merged commit b6f1ca8 into master Dec 30, 2021
@daskyrk daskyrk deleted the hotfix/new-theme branch January 4, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot feature new feature
Development

Successfully merging this pull request may close these issues.

None yet

3 participants