Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1.2): fix issue releations error #902

Merged
merged 2 commits into from Aug 10, 2021
Merged

fix(1.2): fix issue releations error #902

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbf6489
fix: fxi issue releations error
laojun Aug 10, 2021
0301833
fix: Simplify the code
laojun Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 9 additions & 14 deletions shell/app/modules/project/common/components/issue/issue-relation.tsx
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@

import { useUpdate, MemberSelector, IF } from 'common';
import { Button, Select, Table, Popconfirm, Title, Tooltip } from 'core/nusi';
import React from 'react';
import React, { useImperativeHandle } from 'react';
import i18n from 'i18n';
import routeInfoStore from 'core/stores/route';
import issueStore from 'project/stores/issues';
Expand Down Expand Up @@ -59,23 +59,18 @@ export const IssueRelation = React.forwardRef((props: IProps, ref: any) => {
const defaultIssueType = initTypeMap[issueType];
const { getIssueRelation, addIssueRelation, deleteIssueRelation } = issueStore.effects;

React.useEffect(() => {
if (!ref.current) {
// eslint-disable-next-line no-param-reassign
ref.current = { getList };
}
});

const curIterationID = React.useMemo(() => {
return issueDetail.iterationID || iterationID;
}, [issueDetail.iterationID, iterationID]);

const getList = () => {
const getList = React.useCallback(() => {
getIssueRelation({ id: issueDetail.id }).then((res) => {
setRelatingList(res[0]);
setRelatedList(res[1]);
});
};
}, [getIssueRelation, issueDetail]);

useImperativeHandle(ref, () => ({ getList }), [getList]);

const curIterationID = React.useMemo(() => {
return issueDetail.iterationID || iterationID;
}, [issueDetail.iterationID, iterationID]);

useMount(() => {
getList();
Expand Down