-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pipeline task container terminus define tag env #1585
Merged
erda-bot
merged 2 commits into
erda-project:master
from
chengjoey:feature/pipeline-task-container-label
Aug 30, 2021
Merged
Feature/pipeline task container terminus define tag env #1585
erda-bot
merged 2 commits into
erda-project:master
from
chengjoey:feature/pipeline-task-container-label
Aug 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1cd0482
to
1a41d1f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1585 +/- ##
==========================================
+ Coverage 12.62% 12.65% +0.03%
==========================================
Files 1037 1038 +1
Lines 109279 109358 +79
==========================================
+ Hits 13794 13844 +50
- Misses 93909 93935 +26
- Partials 1576 1579 +3
|
c3d1bb8
to
6821295
Compare
fix conflict. |
6821295
to
be65fa0
Compare
be65fa0
to
c4d50d9
Compare
sfwn
approved these changes
Aug 30, 2021
/approve |
erda-bot
approved these changes
Aug 30, 2021
/cherry-pick release/1.2 |
Automated cherry pick failed, please resolve the confilcts and create PR manually.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Add one of the following kinds:
/kind feature
What this PR does / why we need it:
record container env for k8sjob,k8sflink
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @your-reviewer