Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: check if addon exists when project delete #1615

Merged

Conversation

littlejiancc
Copy link
Contributor

What type of this PR

/kind feature

What this PR does / why we need it:

feature: check if addon exists when project delete

Which issue(s) this PR fixes:

删除项目时没有校验里面还有扩展服务未清理

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English check if addon exists when project delete
🇨🇳 中文 删除项目时校验是否还有扩展服务未清理

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from sfwn August 31, 2021 07:25
@littlejiancc littlejiancc added dop devops plaoform feature labels Aug 31, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1615 (a690e43) into master (1e22710) will increase coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1615   +/-   ##
=======================================
  Coverage   12.98%   12.99%           
=======================================
  Files        1042     1042           
  Lines      108746   108755    +9     
=======================================
+ Hits        14121    14129    +8     
+ Misses      93347    93334   -13     
- Partials     1278     1292   +14     
Impacted Files Coverage Δ
modules/core-services/services/project/project.go 8.03% <20.00%> (+1.21%) ⬆️

@sfwn
Copy link
Member

sfwn commented Sep 1, 2021

/approve

@erda-bot erda-bot merged commit 530d734 into erda-project:master Sep 1, 2021
@littlejiancc littlejiancc deleted the feature/dop-project-runtime branch March 29, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants