fix(scheduler): compose deployment with imagepullsecrets #2456
+121
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/1.3 #2456 +/- ##
===============================================
+ Coverage 15.95% 16.08% +0.13%
===============================================
Files 1211 1211
Lines 122014 122062 +48
===============================================
+ Hits 19467 19636 +169
+ Misses 100531 100348 -183
- Partials 2016 2078 +62
|
luobily
reviewed
Oct 27, 2021
| @@ -455,6 +457,11 @@ func (k *Kubernetes) newDeployment(service *apistructs.Service, sg *apistructs.S | |||
| Labels: make(map[string]string), | |||
| }, | |||
| Spec: apiv1.PodSpec{ | |||
| ImagePullSecrets: []apiv1.LocalObjectReference{ | |||
| { | |||
| Name: AliyunRegistry, | |||
There was a problem hiding this comment.
ImagePullSecrets can be used as an environment variable
| if err == nil { | ||
| deployment.Spec.Template.Spec.ImagePullSecrets = []apiv1.LocalObjectReference{ | ||
| { | ||
| Name: AliyunRegistry, |
|
/approve |
|
/cherry-pick master |
|
/cherry-pick release/1.4 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Oct 28, 2021
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Oct 28, 2021
erda-bot
added a commit
that referenced
this pull request
Oct 28, 2021
sfwn
pushed a commit
that referenced
this pull request
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Add one of the following kinds:
/kind bugfix
What this PR does / why we need it:
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @luobily
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.