Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue gantt component data default value reset #2504

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

shuofan
Copy link
Contributor

@shuofan shuofan commented Oct 25, 2021

What type of this PR

bug

What this PR does / why we need it:

Fix issue gantt component data default value reset

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from sfwn October 25, 2021 01:39
@shuofan shuofan added bugfix dop devops plaoform labels Oct 25, 2021
sfwn
sfwn previously approved these changes Oct 25, 2021
@sfwn
Copy link
Member

sfwn commented Oct 25, 2021

/approve

erda-bot
erda-bot previously approved these changes Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #2504 (84b955e) into master (85a83eb) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2504      +/-   ##
==========================================
+ Coverage   16.09%   16.12%   +0.02%     
==========================================
  Files        1236     1236              
  Lines      125580   125680     +100     
==========================================
+ Hits        20214    20263      +49     
- Misses     103237   103323      +86     
+ Partials     2129     2094      -35     
Impacted Files Coverage Δ
...tocol/components/issue-manage/issueGantt/render.go 9.37% <100.00%> (+3.07%) ⬆️
modules/cmp/steve/proxy/cache_store.go 46.51% <0.00%> (-6.93%) ⬇️
...ore/monitor/log/storage/kubernetes-logs/storage.go 59.71% <0.00%> (-4.85%) ⬇️
...ules/scheduler/executor/plugins/k8s/check_quota.go 18.29% <0.00%> (-2.26%) ⬇️
...s/cmp-dashboard-podDetail/containerTable/render.go 4.97% <0.00%> (-2.21%) ⬇️
modules/core/monitor/collector/provider.go 7.69% <0.00%> (-1.84%) ⬇️
...omponents/cmp-dashboard-nodes/nodeFilter/render.go 20.40% <0.00%> (-1.54%) ⬇️
...nents/cmp-dashboard-podDetail/eventTable/render.go 39.16% <0.00%> (-0.56%) ⬇️
modules/cmp/steve/middleware/audit.go 31.87% <0.00%> (-0.43%) ⬇️
modules/cmp/cache/cache.go 64.56% <0.00%> (-0.02%) ⬇️
... and 11 more

@shuofan shuofan dismissed stale reviews from erda-bot and sfwn via 84b955e October 25, 2021 08:07
@sfwn
Copy link
Member

sfwn commented Oct 25, 2021

/approve

@erda-bot erda-bot merged commit 4cf47c8 into erda-project:master Oct 25, 2021
@shuofan shuofan deleted the bug/issue-gantt-data branch October 26, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants