Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rerun and rerun failed pipeline don't use cron time #2560

Merged

Conversation

chengjoey
Copy link
Contributor

What type of this PR

Add one of the following kinds:
/kind bug

What this PR does / why we need it:

rerun and rerun failed pipeline don't use cron time

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@chengjoey chengjoey added bug pipeline pipeline service labels Oct 26, 2021
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #2560 (301091a) into master (2bb3969) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2560   +/-   ##
=======================================
  Coverage   16.33%   16.34%           
=======================================
  Files        1255     1255           
  Lines      127312   127321    +9     
=======================================
+ Hits        20796    20805    +9     
+ Misses     104400   104384   -16     
- Partials     2116     2132   +16     
Impacted Files Coverage Δ
modules/pipeline/services/pipelinesvc/convert.go 51.88% <50.00%> (-0.12%) ⬇️
...ios/auto-test-plan-list/components/table/render.go 46.58% <0.00%> (+0.33%) ⬆️
modules/dop/services/testplan/testplan.go 23.52% <0.00%> (+0.99%) ⬆️

@chengjoey chengjoey requested a review from sfwn October 26, 2021 13:03
@sfwn
Copy link
Member

sfwn commented Oct 27, 2021

add screenshot of test.

@chengjoey
Copy link
Contributor Author

image
6,7,10 is rerun pipeline
image

@sfwn
Copy link
Member

sfwn commented Oct 27, 2021

/approve

@erda-bot erda-bot merged commit 48c906c into erda-project:master Oct 27, 2021
@chengjoey
Copy link
Contributor Author

/cherry-pick release/1.3

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Oct 27, 2021
erda-bot added a commit that referenced this pull request Oct 27, 2021
Co-authored-by: chengjoey <30427474+chengjoey@users.noreply.github.com>
@chengjoey
Copy link
Contributor Author

/cherry-pick release/1.4

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Oct 27, 2021
erda-bot added a commit that referenced this pull request Oct 27, 2021
Co-authored-by: chengjoey <30427474+chengjoey@users.noreply.github.com>
@chengjoey chengjoey deleted the fix/pipeline-cron-trigger-time branch November 15, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants