Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write data to etcd after handleServiceGroup func #2604

Merged
merged 1 commit into from
Oct 28, 2021
Merged

fix: write data to etcd after handleServiceGroup func #2604

merged 1 commit into from
Oct 28, 2021

Conversation

Muzry
Copy link
Contributor

@Muzry Muzry commented Oct 27, 2021

What type of this PR

Add one of the following kinds:
/kind bug

What this PR does / why we need it:

  • fix: write data to etcd after handleServiceGroup func

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @luobily

ChangeLog

Language Changelog
🇺🇸 English Bugfix: Fix the bug that writes the data to etcd after handleServiceGroup function
🇨🇳 中文 现在 scheduler 会在处理 servicegroup 之后再把数据写入 etcd

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from luobily October 27, 2021 08:55
@Muzry Muzry added bugfix orchestrator workload management labels Oct 27, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #2604 (defe579) into master (4737d03) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2604      +/-   ##
==========================================
+ Coverage   16.44%   16.47%   +0.02%     
==========================================
  Files        1259     1259              
  Lines      127757   127886     +129     
==========================================
+ Hits        21010    21066      +56     
- Misses     104552   104595      +43     
- Partials     2195     2225      +30     
Impacted Files Coverage Δ
modules/cmp/component-protocol/cputil/util.go 17.39% <0.00%> (-25.09%) ⬇️
pkg/mock/mock.go 42.42% <0.00%> (-3.04%) ⬇️
...les/core/monitor/log/storage/cassandra/iterator.go 12.76% <0.00%> (-0.55%) ⬇️
...dules/core/monitor/alert/alert-apis/adapt/alert.go 13.53% <0.00%> (-0.33%) ⬇️
...col/components/cmp-dashboard-pods/filter/render.go 8.77% <0.00%> (-0.14%) ⬇️
modules/core/monitor/storekit/writer.go 0.00% <0.00%> (ø)
...omponents/cmp-dashboard-nodes/nodeFilter/render.go 20.40% <0.00%> (ø)
...p-dashboard-workloads-list/workloadTable/render.go 55.32% <0.00%> (+0.07%) ⬆️
pkg/parser/pipelineyml/visitor_ref_op.go 46.77% <0.00%> (+0.53%) ⬆️
...ponents/cmp-dashboard-events-list/filter/render.go 16.33% <0.00%> (+0.75%) ⬆️
... and 9 more

@luobily
Copy link
Member

luobily commented Oct 28, 2021

/approve

@erda-bot erda-bot merged commit b34578e into erda-project:master Oct 28, 2021
@Muzry
Copy link
Contributor Author

Muzry commented Oct 28, 2021

/cherry-pick release/1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants