Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/autotest file record #2624

Merged

Conversation

chengjoey
Copy link
Contributor

What type of this PR

Add one of the following kinds:
/kind bug

What this PR does / why we need it:

fix autotest space file record status error
add scene set name to excel file name

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English Fix the bug that autotest space file record status error
🇨🇳 中文 修复了文件导入记录与空间状态不符, 导出场景集名称在文件名上

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@chengjoey chengjoey added the dop devops plaoform label Oct 27, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #2624 (468100d) into master (48c906c) will increase coverage by 0.09%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2624      +/-   ##
==========================================
+ Coverage   16.35%   16.45%   +0.09%     
==========================================
  Files        1255     1259       +4     
  Lines      127438   127754     +316     
==========================================
+ Hits        20841    21016     +175     
- Misses     104416   104570     +154     
+ Partials     2181     2168      -13     
Impacted Files Coverage Δ
modules/dop/services/autotest_v2/space_data.go 5.88% <37.93%> (+5.88%) ⬆️
modules/dop/services/autotest_v2/export.go 10.96% <100.00%> (ø)
modules/cmp/resource/class.go 23.51% <0.00%> (-3.66%) ⬇️
modules/cmp/resource/summary.go 30.98% <0.00%> (-2.87%) ⬇️
.../cmp-dashboard-nodeDetail/yamlFileEditor/render.go 27.83% <0.00%> (-2.85%) ⬇️
modules/admin/manager/cluster.go 12.34% <0.00%> (-1.17%) ⬇️
modules/cmp/resource/report_table.go 9.40% <0.00%> (-0.70%) ⬇️
modules/core-services/services/project/project.go 8.42% <0.00%> (-0.01%) ⬇️
apistructs/org.go 0.00% <0.00%> (ø)
apistructs/core_services_quota.go 56.00% <0.00%> (ø)
... and 26 more

@chengjoey
Copy link
Contributor Author

chengjoey commented Oct 27, 2021

image
image

make status unanimous

@chengjoey chengjoey force-pushed the fix/autotest-file-record-status branch 2 times, most recently from 67a5609 to 30c5915 Compare October 27, 2021 12:41
@chengjoey chengjoey force-pushed the fix/autotest-file-record-status branch from 30c5915 to 468100d Compare October 27, 2021 13:06
@sfwn
Copy link
Member

sfwn commented Oct 28, 2021

/approve

@erda-bot erda-bot merged commit 5ddd796 into erda-project:master Oct 28, 2021
@chengjoey
Copy link
Contributor Author

/cherry-pick release/1.4

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Oct 28, 2021
* clear api test after submit success

* don't need use goroutine

* don't need use goroutine
erda-bot added a commit that referenced this pull request Oct 28, 2021
* clear api test after submit success

* don't need use goroutine

* don't need use goroutine

Co-authored-by: chengjoey <30427474+chengjoey@users.noreply.github.com>
dspo pushed a commit to dspo/erda that referenced this pull request Oct 28, 2021
* clear api test after submit success

* don't need use goroutine

* don't need use goroutine

Co-authored-by: chengjoey <30427474+chengjoey@users.noreply.github.com>
@chengjoey chengjoey deleted the fix/autotest-file-record-status branch November 15, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dop devops plaoform
Development

Successfully merging this pull request may close these issues.

None yet

3 participants