Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the container env when scale the service group #2672

Merged
merged 1 commit into from
Oct 29, 2021
Merged

fix: update the container env when scale the service group #2672

merged 1 commit into from
Oct 29, 2021

Conversation

Muzry
Copy link
Contributor

@Muzry Muzry commented Oct 28, 2021

What type of this PR

Add one of the following kinds:
/kind bug

What this PR does / why we need it:

  • fix: update the container env when scale the service group

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @luobily

ChangeLog

Language Changelog
🇺🇸 English Bugfix: Fix the bug that will not update the resource environment variables of the container when scaling the service group
🇨🇳 中文 修复扩展 Service Group 时不会更新容器资源环境变量的bug

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from luobily October 28, 2021 10:56
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #2672 (8f8db4a) into master (6b117e6) will increase coverage by 0.07%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2672      +/-   ##
==========================================
+ Coverage   16.59%   16.67%   +0.07%     
==========================================
  Files        1260     1263       +3     
  Lines      128313   128438     +125     
==========================================
+ Hits        21292    21412     +120     
- Misses     104766   104821      +55     
+ Partials     2255     2205      -50     
Impacted Files Coverage Δ
...dules/scheduler/executor/plugins/k8s/deployment.go 32.50% <92.59%> (+7.86%) ⬆️
modules/cmp/resource/summary.go 36.87% <0.00%> (-7.50%) ⬇️
modules/msp/apm/trace/trace.service.go 31.35% <0.00%> (-1.03%) ⬇️
modules/dop/services/autotest_v2/export.go 11.40% <0.00%> (-0.88%) ⬇️
modules/cmp/tasks/collect_daily_quota.go 8.23% <0.00%> (-0.36%) ⬇️
...es/core/monitor/event/query/event.query.service.go 70.45% <0.00%> (ø)
modules/core/monitor/event/query/mock_storage.go 62.50% <0.00%> (ø)
modules/core/monitor/event/query/provider.go 27.27% <0.00%> (ø)
modules/cmp/resource/modal.go 18.18% <0.00%> (+0.79%) ⬆️
modules/pipeline/services/pipelinesvc/create.go 24.04% <0.00%> (+0.93%) ⬆️
... and 5 more

@Muzry Muzry added bugfix orchestrator workload management labels Oct 29, 2021
@luobily
Copy link
Member

luobily commented Oct 29, 2021

/approve

@erda-bot erda-bot merged commit 65dcdaa into erda-project:master Oct 29, 2021
@luobily
Copy link
Member

luobily commented Oct 29, 2021

/cherry-pick release/1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants