-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem that one of the tasks in the automated test pipeline may be in execution after canceling #2684
Merged
Effet
merged 14 commits into
erda-project:master
from
kakj-go:feature/cancel-pipeline-not-create-pipeline
Oct 29, 2021
Merged
Fix the problem that one of the tasks in the automated test pipeline may be in execution after canceling #2684
Effet
merged 14 commits into
erda-project:master
from
kakj-go:feature/cancel-pipeline-not-create-pipeline
Oct 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated cherry pick can ONLY be triggered when this PR is MERGED! |
Codecov Report
@@ Coverage Diff @@
## master #2684 +/- ##
==========================================
- Coverage 16.65% 16.65% -0.01%
==========================================
Files 1263 1263
Lines 128389 128408 +19
==========================================
+ Hits 21379 21382 +3
- Misses 104798 104819 +21
+ Partials 2212 2207 -5
|
…as been cancelled.
41bed50
to
ed997fc
Compare
Effet
approved these changes
Oct 29, 2021
/cherry-pick release/1.4 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Oct 29, 2021
…may be in execution after canceling (erda-project#2684) * update projectID to projectId (erda-project#2534) * It is possible that one of the tasks in the automated test pipeline has been cancelled. Co-authored-by: littlejian <17816869670@163.com>
Effet
pushed a commit
that referenced
this pull request
Oct 29, 2021
…may be in execution after canceling (#2684) (#2689) * update projectID to projectId (#2534) * It is possible that one of the tasks in the automated test pipeline has been cancelled. Co-authored-by: littlejian <17816869670@163.com> Co-authored-by: kakj <18579115540@163.com> Co-authored-by: littlejian <17816869670@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
/kind bug
What this PR does / why we need it:
The cancellation of the automated test pipeline may cause one of the tasks to be executed all the time, which will cause confusion for users
Which issue(s) this PR fixes:
ChangeLog
Need cherry-pick to release versions?
/cherry-pick release/1.4