Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem that one of the tasks in the automated test pipeline may be in execution after canceling #2684

Merged

Conversation

kakj-go
Copy link
Contributor

@kakj-go kakj-go commented Oct 29, 2021

What type of this PR

/kind bug

What this PR does / why we need it:

The cancellation of the automated test pipeline may cause one of the tasks to be executed all the time, which will cause confusion for users

Which issue(s) this PR fixes:

ChangeLog

Language Changelog
🇺🇸 English Fix the problem that one of the tasks in the automated test pipeline may be in execution after canceling
🇨🇳 中文 修复自动化测试流水线中的一项任务取消后可能正在执行的问题

Need cherry-pick to release versions?

/cherry-pick release/1.4

@erda-bot
Copy link
Member

Automated cherry pick can ONLY be triggered when this PR is MERGED!

@kakj-go kakj-go requested a review from sfwn October 29, 2021 03:31
@kakj-go kakj-go added pipeline pipeline service dop devops plaoform bug labels Oct 29, 2021
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #2684 (ed997fc) into master (da0feca) will decrease coverage by 0.00%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2684      +/-   ##
==========================================
- Coverage   16.65%   16.65%   -0.01%     
==========================================
  Files        1263     1263              
  Lines      128389   128408      +19     
==========================================
+ Hits        21379    21382       +3     
- Misses     104798   104819      +21     
+ Partials     2212     2207       -5     
Impacted Files Coverage Δ
modules/pipeline/services/pipelinesvc/create.go 24.04% <38.46%> (+0.93%) ⬆️
modules/cmp/tasks/collect_daily_quota.go 8.23% <0.00%> (-0.36%) ⬇️
...dules/core/monitor/alert/alert-apis/adapt/alert.go 13.53% <0.00%> (-0.33%) ⬇️
modules/core-services/services/project/project.go 9.97% <0.00%> (-0.01%) ⬇️
...dules/scheduler/executor/plugins/k8s/deployment.go 29.80% <0.00%> (ø)

@kakj-go kakj-go force-pushed the feature/cancel-pipeline-not-create-pipeline branch from 41bed50 to ed997fc Compare October 29, 2021 06:33
@Effet Effet merged commit 11e5f9c into erda-project:master Oct 29, 2021
@Effet
Copy link
Member

Effet commented Oct 29, 2021

/cherry-pick release/1.4

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Oct 29, 2021
…may be in execution after canceling (erda-project#2684)

* update projectID to projectId (erda-project#2534)

* It is possible that one of the tasks in the automated test pipeline has been cancelled.

Co-authored-by: littlejian <17816869670@163.com>
Effet pushed a commit that referenced this pull request Oct 29, 2021
…may be in execution after canceling (#2684) (#2689)

* update projectID to projectId (#2534)

* It is possible that one of the tasks in the automated test pipeline has been cancelled.

Co-authored-by: littlejian <17816869670@163.com>

Co-authored-by: kakj <18579115540@163.com>
Co-authored-by: littlejian <17816869670@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dop devops plaoform pipeline pipeline service
Development

Successfully merging this pull request may close these issues.

None yet

4 participants