Fix the error when the user did not fill in the .yml when creating the pipeline #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated cherry pick can ONLY be triggered when this PR is MERGED! |
Codecov Report
@@ Coverage Diff @@
## master #2685 +/- ##
==========================================
- Coverage 16.65% 16.65% -0.01%
==========================================
Files 1263 1262 -1
Lines 128389 128349 -40
==========================================
- Hits 21379 21372 -7
+ Misses 104798 104744 -54
- Partials 2212 2233 +21
|
Effet
suggested changes
Oct 29, 2021
...es/openapi/component-protocol/scenarios/app-pipeline-tree/components/nodeFormModal/render.go
Show resolved
Hide resolved
kakj-go
force-pushed
the
feature/create-pipeline-yml-auito-append-yml
branch
from
f50b773
to
bf15c94
Compare
…lled in automatically when creating
kakj-go
force-pushed
the
feature/create-pipeline-yml-auito-append-yml
branch
from
bf15c94
to
e0fb2a5
Compare
Effet
approved these changes
Oct 29, 2021
|
/approve |
erda-bot
approved these changes
Oct 29, 2021
|
/cherry-pick release/1.4 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Oct 29, 2021
…e pipeline (erda-project#2685) * update projectID to projectId (erda-project#2534) * Assuming that the user did not fill in the .yml suffix, it will be filled in automatically when creating Co-authored-by: littlejian <17816869670@163.com>
erda-bot
added a commit
that referenced
this pull request
Oct 29, 2021
…e pipeline (#2685) (#2693) * update projectID to projectId (#2534) * Assuming that the user did not fill in the .yml suffix, it will be filled in automatically when creating Co-authored-by: littlejian <17816869670@163.com> Co-authored-by: kakj <18579115540@163.com> Co-authored-by: littlejian <17816869670@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
/kind bug
What this PR does / why we need it:
An error is reported when the user does not fill in the .yml when creating the pipeline, which is a bad experience for the user
Which issue(s) this PR fixes:
ChangeLog
Need cherry-pick to release versions?
/cherry-pick release/1.4