Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send pop out pipeline id to etcd, and watch pop out in leader #2742

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

chengjoey
Copy link
Contributor

What type of this PR

Add one of the following kinds:
/kind bug

What this PR does / why we need it:

queue manager send pop out pipeline id to etcd, and watch pop out in leader

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@chengjoey chengjoey added bugfix pipeline pipeline service labels Nov 1, 2021
@chengjoey chengjoey requested a review from sfwn November 1, 2021 09:55
@chengjoey
Copy link
Contributor Author

chengjoey commented Nov 1, 2021

image
image

after cancel

image
image
image

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #2742 (27610ac) into master (0845947) will increase coverage by 0.13%.
The diff coverage is 21.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2742      +/-   ##
==========================================
+ Coverage   16.74%   16.88%   +0.13%     
==========================================
  Files        1261     1266       +5     
  Lines      128238   128732     +494     
==========================================
+ Hits        21477    21734     +257     
- Misses     104555   104751     +196     
- Partials     2206     2247      +41     
Impacted Files Coverage Δ
modules/pipeline/endpoints/pipeline.go 0.00% <0.00%> (ø)
...les/pipeline/pipengine/reconciler/before_listen.go 0.00% <0.00%> (ø)
.../pipengine/reconciler/queuemanage/manager/queue.go 15.78% <23.52%> (+4.02%) ⬆️
modules/cmp/steve/middleware/dispatcher.go 42.05% <0.00%> (-10.85%) ⬇️
modules/cmp/steve/middleware/audit.go 31.72% <0.00%> (-0.16%) ⬇️
...col/components/cmp-dashboard-pods/filter/render.go 8.71% <0.00%> (-0.11%) ⬇️
modules/dop/endpoints/pipeline.go 5.19% <0.00%> (-0.02%) ⬇️
apistructs/pipeline.go 0.00% <0.00%> (ø)
modules/core-services/provider.go 60.00% <0.00%> (ø)
modules/core-services/initialize.go 0.00% <0.00%> (ø)
... and 10 more

@sfwn
Copy link
Member

sfwn commented Nov 2, 2021

/approve

@erda-bot erda-bot merged commit c3c9fd8 into erda-project:master Nov 2, 2021
@sfwn
Copy link
Member

sfwn commented Nov 2, 2021

/cherry-pick release/1.4

@sfwn
Copy link
Member

sfwn commented Nov 2, 2021

/cherry-pick release/1.3

erda-bot added a commit that referenced this pull request Nov 2, 2021
…#2770)

Co-authored-by: chengjoey <30427474+chengjoey@users.noreply.github.com>
erda-bot added a commit that referenced this pull request Nov 2, 2021
…#2769)

Co-authored-by: chengjoey <30427474+chengjoey@users.noreply.github.com>
@chengjoey chengjoey deleted the fix/pipeline-queue-cancel branch November 15, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants