Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loop task not reset begintime #2816

Merged

Conversation

kakj-go
Copy link
Contributor

@kakj-go kakj-go commented Nov 3, 2021

What type of this PR

/kind bugfix

What this PR does / why we need it:

The start execution time is not reset when the pipeline cyclic task is executed. The result of the reset is that the user cannot know the execution time of the cyclic task

Which issue(s) this PR fixes:

ChangeLog

Language Changelog
🇺🇸 English The pipeline does not reset the start execution time of the cyclic task
🇨🇳 中文 pipeline 不重置循环任务的开始执行时间

Need cherry-pick to release versions?

/cherry-pick release/1.4

@erda-bot
Copy link
Member

erda-bot commented Nov 3, 2021

Automated cherry pick can ONLY be triggered when this PR is MERGED!

@kakj-go kakj-go force-pushed the feature/loop-task-not-reset-begintime branch from 1cc054e to 88a5abf Compare November 3, 2021 06:02
@kakj-go kakj-go requested a review from sfwn November 3, 2021 06:02
@kakj-go kakj-go added bug pipeline pipeline service labels Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #2816 (39dd23f) into master (2eaec92) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2816      +/-   ##
==========================================
+ Coverage   16.86%   16.96%   +0.10%     
==========================================
  Files        1284     1285       +1     
  Lines      130955   131094     +139     
==========================================
+ Hits        22080    22245     +165     
+ Misses     106589   106552      -37     
- Partials     2286     2297      +11     
Impacted Files Coverage Δ
...pipeline/pipengine/reconciler/taskrun/task_loop.go 80.88% <ø> (-0.28%) ⬇️
...eline/pipengine/reconciler/taskrun/taskop/queue.go 15.06% <100.00%> (+15.06%) ⬆️
modules/cmp/steve/handler.go 15.68% <0.00%> (-6.54%) ⬇️
modules/cmp/steve_request.go 0.48% <0.00%> (-0.01%) ⬇️
modules/cmp/cluster_resource.go 0.00% <0.00%> (ø)
modules/cmp/steve/parse.go 61.29% <0.00%> (ø)
modules/msp/apm/trace/trace.service.go 31.49% <0.00%> (+0.61%) ⬆️
modules/cmp/resource/report_table.go 12.84% <0.00%> (+0.87%) ⬆️
modules/monitor/apm/topology/topology.go 27.55% <0.00%> (+2.38%) ⬆️
modules/dop/services/pipeline/pipeline.go 16.70% <0.00%> (+5.31%) ⬆️
... and 3 more

@kakj-go kakj-go force-pushed the feature/loop-task-not-reset-begintime branch from 88a5abf to 39dd23f Compare November 3, 2021 09:32
@kakj-go
Copy link
Contributor Author

kakj-go commented Nov 3, 2021

test image:

not loop task cost time

image

loop task cost time

image

@sfwn
Copy link
Member

sfwn commented Nov 3, 2021

/approve

@erda-bot erda-bot merged commit 5d97689 into erda-project:master Nov 3, 2021
@sfwn
Copy link
Member

sfwn commented Nov 3, 2021

/cherry-pick release/1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants