-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix pipeline repeated execution #2921
bugfix pipeline repeated execution #2921
Conversation
Automated cherry pick can ONLY be triggered when this PR is MERGED! |
240d035
to
64c80bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #2921 +/- ##
==========================================
+ Coverage 17.40% 17.56% +0.15%
==========================================
Files 1306 1325 +19
Lines 133279 134982 +1703
==========================================
+ Hits 23200 23707 +507
- Misses 107702 108826 +1124
- Partials 2377 2449 +72
|
64c80bc
to
6a85437
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split into two commits:
- refactor doWatch
- add
processingPipelines
So reviewer can review it clearly by commits.
DO NOT MIX THEM TOGETHER.
…ed, the pipeline is executed repeatedly
6a85437
to
e0fa354
Compare
/approve |
/cherry-pick release/1.4 |
* Reconciler do watch * After the timing task is turned on and the compensation is not executed, the pipeline is executed repeatedly
/cherry-pick release/1.4 |
/cherry-pick release/1.3 |
* Reconciler do watch * After the timing task is turned on and the compensation is not executed, the pipeline is executed repeatedly
* Reconciler do watch * After the timing task is turned on and the compensation is not executed, the pipeline is executed repeatedly
What type of this PR
/kind bugfix
What this PR does / why we need it:
After the timing task is turned on and the compensation is not executed, the pipeline is repeatedly executed, which will cause the pipeline to directly change to the successful state, and the task state in the pipeline is noNeedBySystem
Which issue(s) this PR fixes:
ChangeLog
Need cherry-pick to release versions?