Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix pipeline repeated execution #2921

Merged

Conversation

kakj-go
Copy link
Contributor

@kakj-go kakj-go commented Nov 8, 2021

What type of this PR

/kind bugfix

What this PR does / why we need it:

After the timing task is turned on and the compensation is not executed, the pipeline is repeatedly executed, which will cause the pipeline to directly change to the successful state, and the task state in the pipeline is noNeedBySystem

Which issue(s) this PR fixes:

ChangeLog

Language Changelog
🇺🇸 English The pipeline adds a map to verify whether the pipeline is running
🇨🇳 中文 流水线增加 map 校验 pipeline 是否正在跑

Need cherry-pick to release versions?

@erda-bot
Copy link
Member

erda-bot commented Nov 8, 2021

Automated cherry pick can ONLY be triggered when this PR is MERGED!

@kakj-go kakj-go requested a review from sfwn November 8, 2021 09:39
@kakj-go kakj-go force-pushed the feature/pipeline-repeated-execution branch from 240d035 to 64c80bc Compare November 8, 2021 09:40
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #2921 (e0fa354) into master (5d85209) will increase coverage by 0.15%.
The diff coverage is 22.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2921      +/-   ##
==========================================
+ Coverage   17.40%   17.56%   +0.15%     
==========================================
  Files        1306     1325      +19     
  Lines      133279   134982    +1703     
==========================================
+ Hits        23200    23707     +507     
- Misses     107702   108826    +1124     
- Partials     2377     2449      +72     
Impacted Files Coverage Δ
modules/pipeline/pipengine/reconciler/define.go 0.00% <0.00%> (ø)
modules/pipeline/pipengine/reconciler/listen.go 28.09% <23.43%> (+13.42%) ⬆️
...dules/pipeline/services/pipelinesvc/create_task.go 83.78% <0.00%> (-1.15%) ⬇️
...es/orchestrator/components/addon/mysql/provider.go 26.47% <0.00%> (-0.81%) ⬇️
pkg/parser/pipelineyml/visitor_ref_op.go 46.23% <0.00%> (-0.54%) ⬇️
...p-dashboard-workloads-list/workloadTable/render.go 55.39% <0.00%> (-0.22%) ⬇️
...ponents/cmp-dashboard-events-list/filter/render.go 15.27% <0.00%> (-0.08%) ⬇️
apistructs/audits.go 0.00% <0.00%> (ø)
modules/cmp/resource/class.go 25.27% <0.00%> (ø)
modules/cmp/metrics/metrics.go 25.11% <0.00%> (ø)
... and 41 more

@kakj-go kakj-go force-pushed the feature/pipeline-repeated-execution branch from 64c80bc to 6a85437 Compare November 9, 2021 02:48
Copy link
Member

@sfwn sfwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split into two commits:

  • refactor doWatch
  • add processingPipelines

So reviewer can review it clearly by commits.
DO NOT MIX THEM TOGETHER.

@kakj-go kakj-go force-pushed the feature/pipeline-repeated-execution branch from 6a85437 to e0fa354 Compare November 9, 2021 03:39
@sfwn
Copy link
Member

sfwn commented Nov 9, 2021

/approve

@erda-bot erda-bot merged commit 4c9434a into erda-project:master Nov 9, 2021
@sfwn
Copy link
Member

sfwn commented Nov 9, 2021

/cherry-pick release/1.4

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Nov 9, 2021
* Reconciler do watch

* After the timing task is turned on and the compensation is not executed, the pipeline is executed repeatedly
@kakj-go
Copy link
Contributor Author

kakj-go commented Dec 3, 2021

/cherry-pick release/1.4

@kakj-go
Copy link
Contributor Author

kakj-go commented Dec 3, 2021

/cherry-pick release/1.3

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Dec 3, 2021
* Reconciler do watch

* After the timing task is turned on and the compensation is not executed, the pipeline is executed repeatedly
erda-bot pushed a commit to erda-bot/erda that referenced this pull request Dec 3, 2021
* Reconciler do watch

* After the timing task is turned on and the compensation is not executed, the pipeline is executed repeatedly
Effet pushed a commit that referenced this pull request Dec 3, 2021
* Reconciler do watch

* After the timing task is turned on and the compensation is not executed, the pipeline is executed repeatedly

Co-authored-by: kakj <18579115540@163.com>
Effet pushed a commit that referenced this pull request Dec 3, 2021
* Reconciler do watch

* After the timing task is turned on and the compensation is not executed, the pipeline is executed repeatedly

Co-authored-by: kakj <18579115540@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants