Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set pathType when creating ingress #3322

Merged
merged 2 commits into from Dec 9, 2021

Conversation

dspo
Copy link
Contributor

@dspo dspo commented Dec 9, 2021

What type of this PR

Add one of the following kinds:
/kind feature

What this PR does / why we need it:

To be compatible with higher versions of kubernetes, set the pathType when creating ingress

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English To be compatible with higher versions of kubernetes, set the pathType when creating ingress
🇨🇳 中文 修复了域名管理部分功能不兼容更高版本 K8s 的问题

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@dspo dspo requested a review from liaobing December 9, 2021 07:59
@dspo dspo added bugfix hepa ingress management labels Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #3322 (fec7833) into master (fb01cc4) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3322      +/-   ##
==========================================
+ Coverage   17.70%   17.80%   +0.09%     
==========================================
  Files        1375     1377       +2     
  Lines      142448   142848     +400     
==========================================
+ Hits        25224    25434     +210     
- Misses     114593   114773     +180     
- Partials     2631     2641      +10     
Impacted Files Coverage Δ
pkg/mock/mock.go 42.42% <0.00%> (-3.04%) ⬇️
.../components/cmp-dashboard-pods/podsTable/render.go 16.12% <0.00%> (-0.63%) ⬇️
...dules/scheduler/executor/plugins/k8s/deployment.go 31.83% <0.00%> (-0.30%) ⬇️
modules/cmp/component-protocol/cputil/util.go 20.00% <0.00%> (-0.17%) ⬇️
...ents/cmp-dashboard-workloads-list/filter/render.go 12.44% <0.00%> (-0.16%) ⬇️
.../fileDetail/fileExecute/executeTaskTable/render.go 26.35% <0.00%> (-0.08%) ⬇️
modules/core-services/endpoints/organization.go 0.80% <0.00%> (-0.02%) ⬇️
modules/dop/services/issue/issue.go 2.95% <0.00%> (-0.02%) ⬇️
apistructs/cmp.go 0.00% <0.00%> (ø)
pkg/parser/diceyml/errors.go 0.00% <0.00%> (ø)
... and 14 more

@luobily
Copy link
Member

luobily commented Dec 9, 2021

/approve

@erda-bot erda-bot merged commit 10e56ff into erda-project:master Dec 9, 2021
@dspo
Copy link
Contributor Author

dspo commented Dec 9, 2021

/cherry-pick release/1.5-alpha3

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Dec 9, 2021
* fix: set pathType when creating ingress

* feature: rm useless file
erda-bot added a commit that referenced this pull request Dec 9, 2021
* fix: set pathType when creating ingress

* feature: rm useless file

Co-authored-by: 悟空 <rainchan365@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bugfix hepa ingress management
Development

Successfully merging this pull request may close these issues.

None yet

3 participants