Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5812: fix: mysql addon username #5813

Conversation

erda-bot
Copy link
Member

Cherry pick of #5812 on release/2.3.

Squashed commit message:

commit 580a303adeb5f5253342f2b4dffe8aac1166fe96
Author: 悟空 <rainchan365@163.com>
Date:   Thu Apr 13 09:50:17 2023 +0800

    fix: mysql addon username (#5812)
    
    * fix: mysql addon username
    
    * fix: typo
    
    * ut:
    
    * fix: ut failure
    
    * feat: Refining unit tests

What this PR does / why we need it:

修复 mysql addon 未创建 username 的问题.

问题原因: 判断 mysql addon 未指定 create_dbs 时就提前返回了. 期望结果是无论是否指定 create_dbs 都应当返回 username.

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English Fix mysql addon not creating username issue.
🇨🇳 中文 修复 mysql addon 未创建 username 的问题.

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

* fix: mysql addon username

* fix: typo

* ut:

* fix: ut failure

* feat: Refining unit tests
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #5813 (580a303) into release/2.3 (a4bd710) will increase coverage by 0.00%.
The diff coverage is 48.86%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           release/2.3    #5813   +/-   ##
============================================
  Coverage        22.16%   22.17%           
============================================
  Files             1837     1837           
  Lines           203708   203748   +40     
============================================
+ Hits             45158    45182   +24     
- Misses          153362   153368    +6     
- Partials          5188     5198   +10     
Impacted Files Coverage Δ
.../tools/orchestrator/services/addon/addon_status.go 12.77% <0.00%> (-0.09%) ⬇️
...al/apps/msp/apm/checker/apis/checker.v1.service.go 18.21% <44.82%> (+1.51%) ⬆️
.../tools/orchestrator/services/addon/addon_deploy.go 28.24% <65.21%> (+1.74%) ⬆️

... and 8 files with indirect coverage changes

@sixther-dc sixther-dc merged commit 5de51df into erda-project:release/2.3 Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants