Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: domain policy regex #5814

Closed
wants to merge 6 commits into from

Conversation

dspo
Copy link
Contributor

@dspo dspo commented Apr 13, 2023

What this PR does / why we need it:

fix: domain policy regex

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English fix: domain policy regex
🇨🇳 中文 修复 domain-policy 正则表达式错误的问题

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #5814 (4cfde38) into master (f40c992) will decrease coverage by 0.01%.
The diff coverage is 50.84%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5814      +/-   ##
==========================================
- Coverage   22.19%   22.19%   -0.01%     
==========================================
  Files        1837     1837              
  Lines      203652   203756     +104     
==========================================
+ Hits        45202    45223      +21     
- Misses     153256   153339      +83     
  Partials     5194     5194              
Impacted Files Coverage Δ
.../tools/orchestrator/services/addon/addon_status.go 15.90% <0.00%> (+0.10%) ⬆️
.../tools/orchestrator/services/addon/addon_deploy.go 28.24% <65.21%> (+1.74%) ⬆️

... and 13 files with indirect coverage changes

@dspo dspo closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants