fix: domain-policy regex #5815
Merged
fix: domain-policy regex #5815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5815 +/- ##
=======================================
Coverage 22.19% 22.19%
=======================================
Files 1837 1837
Lines 203756 203756
=======================================
Hits 45223 45223
+ Misses 153338 153336 -2
- Partials 5195 5197 +2 |
|
/lgtm |
|
/approve |
erda-bot
approved these changes
Apr 14, 2023
|
/cherry-pick release/2.3 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Apr 14, 2023
erda-bot
added a commit
that referenced
this pull request
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix: domain policy regex
网关的鉴权模型, 会使用正则表达式去匹配 http 请求的域名, 如果能匹配上, 则将鉴权策略应用于该次请求.
鉴权模型里有个 "^(xxx\.com)" 这样的正则表达式, 当请求 xxx.com.cn 这个域名时, 也会被这个正则表达式命中, 因此对 xxx.com.cn 这个域名的请求会被鉴权策略拦截.
本 PR 修复 erda 上关于这段正则表达式生成的部分代码, 使其正确匹配请求的域名.
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @your-reviewer
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.