appModeCheck move to apistructs package #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakj-go
changed the title
sfwn
requested changes
Jun 30, 2021
kakj-go
force-pushed
the
feature/move-app-mod-check
branch
from
4ae601a
to
0f17463
Compare
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
==========================================
- Coverage 10.11% 10.11% -0.01%
==========================================
Files 935 931 -4
Lines 87700 87689 -11
==========================================
- Hits 8875 8873 -2
+ Misses 77898 77891 -7
+ Partials 927 925 -2
|
sfwn
approved these changes
Jun 30, 2021
|
/approve |
erda-bot
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Add one of the following kinds:
/kind feature
What this PR does / why we need it:
dop and core-services same function move to apistructs package