Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Django versions to test #129

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Update Django versions to test #129

merged 1 commit into from
Jan 26, 2022

Conversation

stianjensen
Copy link
Contributor

This removes EOL python 2.7, and all non-LTS django versions that are out of supported.
Also, Django 4.0 which is now released is added to testing.

This removes EOL python 2.7, and all non-LTS django versions that are out of supported.
Also, Django 4.0 which is now released is added to testing.
@stianjensen
Copy link
Contributor Author

Will probably need #127 to make tests pass on Django 4.0

@erdem erdem merged commit 6009e3d into erdem:master Jan 26, 2022
@stianjensen stianjensen deleted the patch-1 branch January 26, 2022 21:48
@stianjensen
Copy link
Contributor Author

Coming back to review my own code with a big facepalm:

I've excluded all tests from running 🤦 Must have not seen the exclude keyword when removing the 2.7 entries...

@erdem
Copy link
Owner

erdem commented Jan 26, 2022

@stianjensen don't worry about your code, this project was integrated into travis-ci.org at the time that I have developed it. I already got migrating issues with travis-ci.com. I thought your changes can trigger a new build on new travis but no luck. I have reverted .travis.yml file and added django.4.0 env to it in the main branch. I will work on this more later.

@stianjensen
Copy link
Contributor Author

@stianjensen don't worry about your code, this project was integrated into travis-ci.org at the time that I have developed it. I already got migrating issues with travis-ci.com. I thought your changes can trigger a new build on new travis but no luck. I have reverted .travis.yml file and added django.4.0 env to it in the main branch. I will work on this more later.

Okay, I see!

I created a new PR to try and cleanup, but feel free to close that again, then 👍 At this point it's probably better to just migrate to Github Actions instead, anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants