Fix some warnings from PyCharm

erdewit · Aug 29, 2023 · 1c4c953 · 1c4c953
1 parent de7cd9d
commit 1c4c953
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/ib_insync/ib.py b/ib_insync/ib.py
@@ -677,8 +677,7 @@ def placeOrder(self, contract: Contract, order: Order) -> Trade:
             orderStatus = OrderStatus(
                 orderId=orderId, status=OrderStatus.PendingSubmit)
             logEntry = TradeLogEntry(now, orderStatus.status)
-            trade = Trade(
-                contract, order, orderStatus, [], [logEntry])
+            trade = Trade(contract, order, orderStatus, [], [logEntry])
             self.wrapper.trades[key] = trade
             self._logger.info(f'placeOrder: New order {trade}')
             self.newOrderEvent.emit(trade)

diff --git a/ib_insync/order.py b/ib_insync/order.py
@@ -238,9 +238,10 @@ class OrderStatus:
     Filled: ClassVar[str] = 'Filled'
     Inactive: ClassVar[str] = 'Inactive'
 
-    DoneStates: ClassVar[Set[str]] = {'Filled', 'Cancelled', 'ApiCancelled'}
-    ActiveStates: ClassVar[Set[str]] = {
-        'PendingSubmit', 'ApiPending', 'PreSubmitted', 'Submitted'}
+    DoneStates: ClassVar[Set[str]] = frozenset(
+        ['Filled', 'Cancelled', 'ApiCancelled'])
+    ActiveStates: ClassVar[Set[str]] = frozenset(
+        ['PendingSubmit', 'ApiPending', 'PreSubmitted', 'Submitted'])
 
 
 @dataclass
@@ -285,18 +286,18 @@ class Trade:
         * ``cancelledEvent`` (trade: :class:`.Trade`)
     """
 
-    events: ClassVar = (
-        'statusEvent', 'modifyEvent', 'fillEvent',
-        'commissionReportEvent', 'filledEvent',
-        'cancelEvent', 'cancelledEvent')
-
     contract: Contract = field(default_factory=Contract)
     order: Order = field(default_factory=Order)
     orderStatus: 'OrderStatus' = field(default_factory=OrderStatus)
     fills: List[Fill] = field(default_factory=list)
     log: List[TradeLogEntry] = field(default_factory=list)
     advancedError: str = ''
 
+    events: ClassVar = (
+        'statusEvent', 'modifyEvent', 'fillEvent',
+        'commissionReportEvent', 'filledEvent',
+        'cancelEvent', 'cancelledEvent')
+
     def __post_init__(self):
         self.statusEvent = Event('statusEvent')
         self.modifyEvent = Event('modifyEvent')