Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error occurs when building v.8.5.2 #209

Closed
Zloi78 opened this issue Jan 1, 2024 · 6 comments
Closed

An error occurs when building v.8.5.2 #209

Zloi78 opened this issue Jan 1, 2024 · 6 comments

Comments

@Zloi78
Copy link

Zloi78 commented Jan 1, 2024

An error occurs when building (via cross build):

2024-01-01_161226

In versions v.8.5.0 and below, there are no problems:

Compiling wstunnel v8.5.0 (/project)
Finished release [optimized + debuginfo] target(s) in 4m 05s

@erebe
Copy link
Owner

erebe commented Jan 1, 2024

Hello,

Do you use rust 1.75 ? If not Would you mind trying with rust 1.75

@Zloi78
Copy link
Author

Zloi78 commented Jan 1, 2024

Thanks.

But there is no target (mipsel-unknown-linux-musl) in version 1.75.
Okay, since the changes are not that significant, I’ll stay on version 8.5.0. :)

Happy New Year!

@erebe
Copy link
Owner

erebe commented Jan 1, 2024

Happy new year to you too :)
If you want, you can comment https://github.com/erebe/wstunnel/blob/main/src/tunnel/tls_reloader.rs#L89 this line. It will not break anything, you just not support edge case where tls certificate are not reloaded on server if you delete the files.

But besides that, everything will be ok

@vercas
Copy link
Contributor

vercas commented Jan 1, 2024

I've got my own fork of wstunnel that I've piped into my CI system, and I sometimes see this error as well... But not all the time. And I have absolutely no idea why.
To add: replacing the certificates is how you should expect users to update them. It is, in fact, more difficult to replace them via traditional file overwrites, with the way Linux tools work.

@erebe
Copy link
Owner

erebe commented Jan 2, 2024

@vercas That's a fair point regarding how users are going to update certs.

Regarding your issue in CI, that's strange because as long as you have Rust 1.75 standard lib, you should have the function. It should not be flaky.

@Zloi78 Do you know if mipsel-unknown-linux-musl target is going to appear at some point for Rust 1.75 ? If not I can make a cfg flags.

Just for information, after I introduce udp association, I plan to make an "LTS" version where i provide a binary for a lot more architecture than what there is today.

@erebe
Copy link
Owner

erebe commented Jan 9, 2024

I made a new release https://github.com/erebe/wstunnel/releases/tag/v9.0.0 which does not depend on rust 1.75 anymore.
So you should be able to get rid of the patch.

@erebe erebe closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants