Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wstunnel: update to 8.5.4 #47948

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

cinerea0
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

@cinerea0 cinerea0 marked this pull request as draft December 29, 2023 19:04
@cinerea0
Copy link
Contributor Author

Version 8.5.2 (the latest as of this comment) requires Rust 1.75.

@leahneukirchen
Copy link
Member

Sure it requires?

@cinerea0
Copy link
Contributor Author

cinerea0 commented Jan 3, 2024

This is the error I get when compiling the new latest version (8.5.4):

error[E0658]: use of unstable library feature 'file_set_times'
  --> src/tunnel/tls_reloader.rs:89:26
   |
89 |             let _ = file.set_modified(SystemTime::now()).map_err(|err| {
   |                          ^^^^^^^^^^^^
   |
   = note: see issue #98245 <https://github.com/rust-lang/rust/issues/98245> for more information

That feature was stabilized in Rust 1.75. However, it can be made to compile by commenting out one small block that supports an edge case (see erebe/wstunnel#209 (comment)). What do you think?

@leahneukirchen
Copy link
Member

sgtm, even if 1.75 will land soon i assume.

@cinerea0 cinerea0 changed the title wstunnel: update to 8.5.0 wstunnel: update to 8.5.4 Jan 3, 2024
@cinerea0 cinerea0 marked this pull request as ready for review January 3, 2024 18:16
@leahneukirchen leahneukirchen merged commit 3a5e8ac into void-linux:master Jan 3, 2024
8 checks passed
@cinerea0 cinerea0 deleted the wstunnel branch January 3, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants