Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use core.info for logging, remove unused fs import #4

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

HarikrishnanBalagopal
Copy link
Contributor

@HarikrishnanBalagopal
Copy link
Contributor Author

I have not changed dist/index.js to keep the diff to a minimum.

@eregon
Copy link
Owner

eregon commented Dec 12, 2020

As far as I know console.log() works fine.
Do you have an example where it's not printed?

What is meant in the docs is core.debug("...") is only shown if enabled, but that's something else.

@eregon
Copy link
Owner

eregon commented Dec 12, 2020

@HarikrishnanBalagopal
Copy link
Contributor Author

What is meant in the docs is core.debug("...") is only shown if enabled, but that's something else.

https://docs.github.com/en/free-pro-team@latest/actions/managing-workflow-runs/enabling-debug-logging
To see core.debug messages you need to set the secret ACTIONS_STEP_DEBUG to true.
Can also set the secret ACTIONS_RUNNER_DEBUG to true for debug messages from the Github runner itself.

@HarikrishnanBalagopal
Copy link
Contributor Author

As far as I know console.log() works fine.
Do you have an example where it's not printed?

I was having problems earlier where it wasn't printed but I tested console.log just now and it seems to work.

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
Copy link
Owner

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup

@eregon eregon merged commit 64e51d0 into eregon:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants