Add support for text/html Accept header #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func LabelColor(status string) string { | ||
| switch status { | ||
| case "TASK_FAILED": | ||
| return "red" |
There was a problem hiding this comment.
colours feels more like a css thing. should the class perhaps just be "task-failed" or so?
There was a problem hiding this comment.
that is very true, maybe I should just export a ToLower function
|
LGTM. Will give it a spin. |
added 6 commits
November 12, 2015 10:42
If accessing a route with text/html in the Accept header render a HTML page instead of returning a JSON.
| </div> | ||
| <div class="ui main container" style="padding-top: 50px;"> | ||
| <div class="ui image content"> | ||
| <img src="static/images/disappointed_minion.png"> |
There was a problem hiding this comment.
guess this should be /static/..
There was a problem hiding this comment.
yes! that's probably why it breaks on that one route
alde
added a commit
that referenced
this pull request
Nov 12, 2015
Add support for text/html Accept header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If accessing a route with text/html in the Accept header render a HTML
page instead of returning a JSON.