Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Limited filters excluded from general filters scope #898

Closed
Sileniful opened this issue Jun 21, 2020 · 4 comments
Closed

Comments

@Sileniful
Copy link

Currently using a limited filter for ER and a general filter for HS and the general filter does not let me download from ER because of a conflict with selecting anime from a specific sub group. Would it be possible to do this? Including current filter setup
ER was set for only this anime

Honzuki no Gekokujou: Shisho ni Naru Tame ni wa Shudan wo Erandeiraremasen 2

for spring season and it was working properly when i was using just limited filters

filters.txt

@erengy
Copy link
Owner

erengy commented Jun 21, 2020

  1. Change the limited filter's action to Prefer so that it selects matching torrents and discards others.

  2. Note that filters are processed from top to bottom. In other words, higher filters are prioritized. While this is not obvious from the UI, you can actually move a general filter below a limited filter: You just need to continue clicking a few times after it reaches the bottom of the group.

  3. Consider disabling the first two general Select filters, or changing the general HorribleSubs filter's action to Prefer. Otherwise you're more likely to have issues such as Select Matched/Prefer Items showing torrent that should be filtered out #897.


Note to self: This might be a good time to remove the groups from the list view and perhaps add unsortable columns (#318).

@Sileniful
Copy link
Author

Sileniful commented Jun 21, 2020

1,3. for someone who just started to work out how the filters work it was not clear what is the difference between prefer and select from just the UI, would it be possible to have some explanation what is the difference in the app?

  1. actually it does not seem to be possible to move a general filter below a limited one in both cases when i reach bottom of general filters list or top of limited i cannot move it below limited

general
image

limited
image

edit
i understand what you mean by arrows now and i agree please do change the view

@paulo27ms
Copy link

Note to self: This might be a good time to remove the groups from the list view and perhaps add unsortable columns (#318).

I'm not misunderstanding Limited filters right? I'm under the impression that Limited filters will execute the preferred filter on a much stronger note, i.e. if I limit an anime to a fansub group it'll only select that group for that anime, meanwhile if I set a General filter then that anime might still get selected for other groups if the preferred group isn't present.
I might be misinterpreting and you'll just remove the groups from the list view but still keep the functionality and make it clear it's a Limited filter through another indicator.
I think this distinct between a Limited filter and a General filter isn't very intuitive either but having them split in two groups makes it somewhat easier to understand with practice rather than if they were all together.

@erengy
Copy link
Owner

erengy commented Jun 21, 2020

for someone who just started to work out how the filters work it was not clear what is the difference between prefer and select from just the UI, would it be possible to have some explanation what is the difference in the app?

There's a section at the support page that explains how torrent filters work, although it doesn't go into every detail. I have some plans to move towards a simpler filtering system, so hopefully that won't require reading an extra manual.

it does not seem to be possible to move a general filter below a limited one in both cases when i reach bottom of general filters list or top of limited i cannot move it below limited

What I meant to say is, the UI doesn't reflect the actual order. While it seems like you're unable to do that, general and limited filters are ordered together.

I'm not misunderstanding Limited filters right? I'm under the impression that Limited filters will execute the preferred filter on a much stronger note

Indeed. From the FAQ page: "Discard and Select actions work the way you'd expect, whereas Prefer is a bit more complicated: If it's a general filter, torrents that don't match the filter are discarded. If it's a limited filter, torrents that match the filter are selected, and torrents that don't match the filter are discarded."

In other words, a general preference filter only discards, while a limited one selects and discards. Of course, there's also the thing you mentioned at #897 (comment).

I might be misinterpreting and you'll just remove the groups from the list view but still keep the functionality and make it clear it's a Limited filter through another indicator.

Yeah, I just meant modifying the UI to something like this, without changing the behavior:

torrent-filters

@erengy erengy closed this as completed Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants