Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot directly serialize PhoneNumber #35

Open
AartBluestoke opened this issue Nov 18, 2020 · 0 comments
Open

cannot directly serialize PhoneNumber #35

AartBluestoke opened this issue Nov 18, 2020 · 0 comments

Comments

@AartBluestoke
Copy link

Because of the publicly visible member "defaultInstanceForType" which is self-referential.
If you are using newtonsoft for searialization this requires serializing everything with "Newtonsoft.Json.ReferenceLoopHandling.Ignore," (which could be dangerous, the default is to throw an exception by default for a good reason),

if you use the new c# language serializer, it will just crash with recursion limit exceeded.

Could the defaultInstanceForType please be annotated with 'don't serialize this', as it isn't part of the object state.

https://dotnetfiddle.net/rJNvxd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant