Enhancement: Add support for PHP 7.2

ergebnis · Feb 18, 2024 · a335032 · a335032
1 parent a9a8f18
commit a335032
Show file tree

Hide file tree

Showing 9 changed files with 27 additions and 13 deletions.
diff --git a/.github/settings.yml b/.github/settings.yml
@@ -21,6 +21,8 @@ branches:
           - context: "Refactoring (7.4, locked)"
           - context: "Security Analysis (7.4, locked)"
           - context: "Static Code Analysis (7.4, locked)"
+          - context: "Tests (7.2, highest)"
+          - context: "Tests (7.2, locked)"
           - context: "Tests (7.3, highest)"
           - context: "Tests (7.3, locked)"
           - context: "Tests (7.4, highest)"

diff --git a/.github/workflows/integrate.yaml b/.github/workflows/integrate.yaml
@@ -429,6 +429,12 @@ jobs:
           - "highest"
 
         include:
+          - php-version: "7.2"
+            dependencies: "lowest"
+
+          - php-version: "7.2"
+            dependencies: "highest"
+
           - php-version: "7.3"
             dependencies: "lowest"
 
@@ -471,7 +477,11 @@ jobs:
 
       - name: "Remove incompatible dependencies with composer"
         if: "matrix.dependencies != 'locked'"
-        run: "composer remove ergebnis/composer-normalize ergebnis/license ergebnis/php-cs-fixer-config infection/infection psalm/plugin-phpunit vimeo/psalm --ansi --dev --no-interaction --no-progress"
+        run: "composer remove ergebnis/composer-normalize ergebnis/license ergebnis/php-cs-fixer-config infection/infection psalm/plugin-phpunit phpunit/phpunit vimeo/psalm --ansi --dev --no-interaction --no-progress"
+
+      - name: "Require phpunit/phpunit"
+        if: "matrix.dependencies != 'locked'"
+        run: "composer require phpunit/phpunit:\"^8.5.19 || ^9.6.16\" --ansi --dev --no-interaction --no-progress"
 
       - name: "Install ${{ matrix.dependencies }} dependencies with composer"
         uses: "ergebnis/.github/actions/composer/install@1.9.0"

diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php
@@ -26,7 +26,7 @@
 
 $license->save();
 
-$ruleSet = PhpCsFixer\Config\RuleSet\Php73::create()->withHeader($license->header());
+$ruleSet = PhpCsFixer\Config\RuleSet\Php72::create()->withHeader($license->header());
 
 $config = PhpCsFixer\Config\Factory::fromRuleSet($ruleSet);
 

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@ For a full diff see [`2.7.0...main`][2.7.0...main].
 - Added support for PHP 8.0 ([#756]), by [@localheinz]
 - Added support for PHP 7.4 ([#757]), by [@localheinz]
 - Added support for PHP 7.3 ([#758]), by [@localheinz]
+- Added support for PHP 7.2 ([#759]), by [@localheinz]
 
 ## [`2.7.0`][2.7.0]
 
@@ -172,6 +173,7 @@ For a full diff see [`36912f6...1.0.0`][36912f6...1.0.0].
 [#756]: https://github.com/ergebnis/clock/pull/756
 [#757]: https://github.com/ergebnis/clock/pull/757
 [#758]: https://github.com/ergebnis/clock/pull/758
+[#759]: https://github.com/ergebnis/clock/pull/759
 
 [@ergebnis]: https://github.com/ergebnis
 [@localheinz]: https://github.com/localheinz
diff --git a/composer.json b/composer.json
@@ -21,15 +21,15 @@
     "source": "https://github.com/ergebnis/clock"
   },
   "require": {
-    "php": "~7.3.0 || ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0",
+    "php": "~7.2.0 || ~7.3.0 || ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0",
     "psr/clock": "^1.0.0"
   },
   "require-dev": {
     "ergebnis/composer-normalize": "^2.42.0",
     "ergebnis/license": "^2.4.0",
     "ergebnis/php-cs-fixer-config": "^6.22.0",
     "infection/infection": "~0.26.6",
-    "phpunit/phpunit": "^9.6.16",
+    "phpunit/phpunit": "^8.5.19 || ^9.6.16",
     "psalm/plugin-phpunit": "~0.18.4",
     "rector/rector": "^1.0.1",
     "vimeo/psalm": "^5.22.1"

diff --git a/composer.lock b/composer.lock
diff --git a/rector.php b/rector.php
@@ -23,9 +23,9 @@
         __DIR__ . '/test/',
     ]);
 
-    $rectorConfig->phpVersion(ValueObject\PhpVersion::PHP_73);
+    $rectorConfig->phpVersion(ValueObject\PhpVersion::PHP_72);
 
     $rectorConfig->sets([
-        PHPUnit\Set\PHPUnitSetList::PHPUNIT_90,
+        PHPUnit\Set\PHPUnitSetList::PHPUNIT_80,
     ]);
 };
diff --git a/src/SystemClock.php b/src/SystemClock.php
@@ -26,7 +26,7 @@ public function now(): \DateTimeImmutable
     {
         return new \DateTimeImmutable(
             'now',
-            $this->timezone,
+            $this->timezone
         );
     }
 

diff --git a/test/Unit/SystemClockTest.php b/test/Unit/SystemClockTest.php
@@ -32,14 +32,14 @@ public function testNowReturnsCurrentDateTime(): void
 
         $before = new \DateTimeImmutable(
             'now',
-            $timeZone,
+            $timeZone
         );
 
         $now = $clock->now();
 
         $after = new \DateTimeImmutable(
             'now',
-            $timeZone,
+            $timeZone
         );
 
         self::assertGreaterThanOrEqual($before, $now);
@@ -54,14 +54,14 @@ public function testFreezeReturnsFrozenClock(): void
 
         $before = new \DateTimeImmutable(
             'now',
-            $timeZone,
+            $timeZone
         );
 
         $frozenClock = $clock->freeze();
 
         $after = new \DateTimeImmutable(
             'now',
-            $timeZone,
+            $timeZone
         );
 
         self::assertInstanceOf(FrozenClock::class, $frozenClock);