Merge pull request #46 from localheinz/fix/rename

Fix: Extract method and rename method to make concepts clear
ergebnis · Feb 13, 2018 · 67cd1cc · 67cd1cc
2 parents 6c0c070 + c534252
commit 67cd1cc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/test/Unit/Normalizer/PackageHashNormalizerTest.php b/test/Unit/Normalizer/PackageHashNormalizerTest.php
@@ -99,19 +99,22 @@ public function testNormalizeSortsPackageHashIfPropertyExists(string $property):
 
     public function providerProperty(): \Generator
     {
-        $values = [
+        foreach ($this->propertiesWhereKeysOfHashArePackages() as $value) {
+            yield $value => [
+                $value,
+            ];
+        }
+    }
+
+    private function propertiesWhereKeysOfHashArePackages(): array
+    {
+        return [
             'conflict',
             'provide',
             'replace',
             'require',
             'require-dev',
             'suggest',
         ];
-
-        foreach ($values as $value) {
-            yield $value => [
-                $value,
-            ];
-        }
     }
 }
diff --git a/test/Unit/Normalizer/VersionConstraintNormalizerTest.php b/test/Unit/Normalizer/VersionConstraintNormalizerTest.php
@@ -66,7 +66,7 @@ public function testNormalizeIgnoresEmptyPackageHash(string $property): void
 
     public function providerProperty(): \Generator
     {
-        $properties = $this->properties();
+        $properties = $this->propertiesWhereValuesOfHashAreVersionConstraints();
 
         foreach ($properties as $property) {
             yield [
@@ -107,7 +107,7 @@ public function testNormalizeNormalizesVersionConstraints(string $property, stri
 
     public function providerPropertyAndVersionConstraint(): \Generator
     {
-        $properties = $this->properties();
+        $properties = $this->propertiesWhereValuesOfHashAreVersionConstraints();
         $versionConstraints = $this->versionConstraints();
 
         foreach ($properties as $property) {
@@ -158,7 +158,7 @@ public function providerPropertyAndUntrimmedVersionConstraint(): \Generator
             ' ',
         ];
 
-        $properties = $this->properties();
+        $properties = $this->propertiesWhereValuesOfHashAreVersionConstraints();
         $versionConstraints = \array_unique(\array_values($this->versionConstraints()));
 
         foreach ($properties as $property) {
@@ -182,7 +182,7 @@ public function providerPropertyAndUntrimmedVersionConstraint(): \Generator
         }
     }
 
-    private function properties(): array
+    private function propertiesWhereValuesOfHashAreVersionConstraints(): array
     {
         return [
             'conflict',