-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Composer 1 support in the 2.x branch #620
Comments
You should be able to address this yourself by using |
That said, yes this is a breaking change and should have been made in a major release, not a patch release. |
I will think about it, but as an alternative, consider updating |
It's not a breaking change, see #597, and in particular, 5413856#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R21. |
@localheinz Thanks for your work on this extension, it's very useful. Why do you not consider dropping support for Composer v1 as a breaking change? |
We do our best to get all envs on Composer 2, but as I wrote above, some environment are not in our control and think we are not the only one. If Composer would know that it should not update to the latest minor/patch version of this library because it dropped Composer 2 support, this would not be an issue, but it does not know that and it won't, Composer maintainers have no interest to have this supported. (Which is fine.) (It is kinda like dropping support of a PHP version in a minor/patch version, which can be considered an edge case, BUT at least Composer can handle it, because it won't install the new version if the runtime environment has an older PHP version than what it is in the |
I need to ask: have you considered sponsoring me to change my mind? |
Originally, I thought about code contribution if restoring Composer 1 compatibility is acceptable, but I'll consider the other option :) |
Released as |
Awesome :) |
You are welcome! |
Hi,
Today we bumped into an issue because Composer 2 compatibility was suddenly dropped by this plugin and our builds have started to break in those environments where still only Composer 1 is available and we have less control over the installed version.
More information in the related Composer issue: composer/composer#9474
Any chance to rollback this PR from the 2.x branch and only drop support of Composer 2 in a new 3.x branch?
The text was updated successfully, but these errors were encountered: