Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Require localheinz/phpstan-rules #105

Merged
merged 3 commits into from
Nov 17, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Nov 13, 2018

This PR

  • requires localheinz/phpstan-rules
  • enables the Localheinz\PHPStan\Rules\Classes\AbstractOrFinalRule rule for phpstan/phpstan
  • removes a test asserting that source classes are abstract or final

@localheinz localheinz self-assigned this Nov 13, 2018
@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #105   +/-   ##
=========================================
  Coverage     72.45%   72.45%           
  Complexity       63       63           
=========================================
  Files             7        7           
  Lines           265      265           
=========================================
  Hits            192      192           
  Misses           73       73

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcf55c2...db7ce9c. Read the comment docs.

@localheinz localheinz merged commit f8b88c9 into master Nov 17, 2018
@localheinz localheinz deleted the feature/phpstan-rules branch November 17, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant