Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not override initialize() #117

Merged
merged 2 commits into from
Dec 9, 2018
Merged

Fix: Do not override initialize() #117

merged 2 commits into from
Dec 9, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 8, 2018

This PR

  • stops overriding initialize() in NormalizeCommand
  • removes brittle tests

Follows #83.

@localheinz localheinz added the bug label Dec 8, 2018
@localheinz localheinz self-assigned this Dec 8, 2018
@localheinz localheinz changed the base branch from master to 1.0 December 8, 2018 18:32
@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #117 into 1.0 will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                1.0    #117      +/-   ##
===========================================
- Coverage     57.05%   56.8%   -0.26%     
+ Complexity       35      34       -1     
===========================================
  Files             2       2              
  Lines           170     169       -1     
===========================================
- Hits             97      96       -1     
  Misses           73      73
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 54.37% <ø> (-0.29%) 31 <0> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd4288a...13a573b. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #117 into 1.0 will decrease coverage by 31.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##                1.0     #117       +/-   ##
=============================================
- Coverage     57.05%   26.03%   -31.03%     
+ Complexity       35       34        -1     
=============================================
  Files             2        2               
  Lines           170      169        -1     
=============================================
- Hits             97       44       -53     
- Misses           73      125       +52
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 21.87% <ø> (-32.79%) 31 <0> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 119083a...072403a. Read the comment docs.

@localheinz localheinz force-pushed the fix/initialize branch 2 times, most recently from c5421de to 1e97d14 Compare December 8, 2018 23:13
@localheinz localheinz merged commit dcba1d5 into 1.0 Dec 9, 2018
@localheinz localheinz deleted the fix/initialize branch December 9, 2018 11:17
@localheinz localheinz mentioned this pull request Dec 14, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant