Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use appropriate data provider #482

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Fix: Use appropriate data provider #482

merged 1 commit into from
Jul 3, 2020

Conversation

localheinz
Copy link
Member

This PR

  • uses an appropriate data provider

@localheinz localheinz self-assigned this Jul 3, 2020
@@ -306,7 +306,7 @@ public function normalize(Json $json): Json
}

/**
* @dataProvider providerCommandInvocationAndInvalidIndentSize
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent size is not relevant in this test, and the provided argument is never used.

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #482 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #482   +/-   ##
=========================================
  Coverage     80.92%   80.92%           
  Complexity       41       41           
=========================================
  Files             4        4           
  Lines           194      194           
=========================================
  Hits            157      157           
  Misses           37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60aa63...57a6967. Read the comment docs.

@ergebnis-bot ergebnis-bot self-requested a review July 3, 2020 17:43
@ergebnis-bot ergebnis-bot self-assigned this Jul 3, 2020
@ergebnis-bot ergebnis-bot merged commit 86c553c into main Jul 3, 2020
@ergebnis-bot ergebnis-bot deleted the fix/provider branch July 3, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants